GetLitFam/esp-hal
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #619 from bjoernQ/i2c-pin-setup-improvement

Browse Source 
Avoid SDA/SCL low  during pin config
This commit is contained in:
Björn Quentin 2023-06-26 12:42:21 +02:00 committed by GitHub
commit 3c4dc8df6a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGELOG.md
View File

@ -54,6 +54,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fixed wrong variable access (FOSC CLK calibration for ESP32-C6 #593) - Fixed wrong variable access (FOSC CLK calibration for ESP32-C6 #593)
- Fixed [trap location in ram](https://github.com/esp-rs/esp-hal/pull/605#issuecomment-1604039683) (#605) - Fixed [trap location in ram](https://github.com/esp-rs/esp-hal/pull/605#issuecomment-1604039683) (#605)
- Fixed a possible overlap of `.data` and `.rwtext` (#616) - Fixed a possible overlap of `.data` and `.rwtext` (#616)
- Avoid SDA/SCL being low while configuring pins for I2C
### Changed ### Changed
@ -63,7 +64,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Breaking ### Breaking
- Significantly simplified user-facing GPIO pin types. (#553) - Significantly simplified user-facing GPIO pin types. (#553)
- No longer re-export the `soc` moduleand the contents of the `interrupt` module at the package level (#607) - No longer re-export the `soc` module and the contents of the `interrupt` module at the package level (#607)
## [0.9.0] - 2023-05-02 ## [0.9.0] - 2023-05-02

5
esp-hal-common/src/i2c.rs
View File

@ -250,7 +250,10 @@ where
let mut i2c = I2C { peripheral: i2c }; let mut i2c = I2C { peripheral: i2c };
// initialize SCL first to not confuse some devices like MPU6050 // avoid SCL/SDA going low during configuration
scl.set_output_high(true);
sda.set_output_high(true);
scl.set_to_open_drain_output() scl.set_to_open_drain_output()
.enable_input(true) .enable_input(true)
.internal_pull_up(true) .internal_pull_up(true)